Skip to content

Add sslmode field to hyperdrive command #8727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

Add sslmode field to hyperdrive command #8727

merged 2 commits into from
Apr 1, 2025
+152 −28

Conversation

@Ltadrian
Copy link
Contributor

@Ltadrian Ltadrian commented Mar 31, 2025 •
edited by petebacondarwin
Loading

Fixes #[insert GH or internal issue link(s)].

  • update mtls_certificate_uuid and ca_certificate_uuid to mtls_certificate_id and ca_certificate_id
  • add sslmode field to hyperdrive create/update wrangler command

CR-1142084

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: new feature

@Ltadrian Ltadrian requested a review from a team as a code owner March 31, 2025 00:18
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c427e75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CarmenPopoviciu
Copy link
Contributor

CarmenPopoviciu commented Mar 31, 2025

this change will require a changeset 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-wrangler-8727

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8727/npm-package-wrangler-8727

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-wrangler-8727 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-workers-bindings-extension-8727 -O ./cloudflare-workers-bindings-extension.0.0.0-v898592576.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v898592576.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-create-cloudflare-8727 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-kv-asset-handler-8727

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-miniflare-8727

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-pages-shared-8727

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-unenv-preset-8727

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-vite-plugin-8727

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-vitest-pool-workers-8727

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-workers-editor-shared-8727

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-workers-shared-8727

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14191616160/npm-package-cloudflare-workflows-shared-8727

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.1
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 31, 2025
@Ltadrian Ltadrian force-pushed the agracia/SQC-480-add-sslmode-hyperdrive branch from 28d6acd to 278815b Compare March 31, 2025 14:06
CarmenPopoviciu
CarmenPopoviciu reviewed Mar 31, 2025
View reviewed changes
CarmenPopoviciu
CarmenPopoviciu reviewed Mar 31, 2025
View reviewed changes
CarmenPopoviciu
CarmenPopoviciu reviewed Mar 31, 2025
View reviewed changes
CarmenPopoviciu
CarmenPopoviciu reviewed Mar 31, 2025
View reviewed changes
CarmenPopoviciu
CarmenPopoviciu reviewed Mar 31, 2025
View reviewed changes
@CarmenPopoviciu
Copy link
Contributor

CarmenPopoviciu commented Mar 31, 2025

This will require a CR to land. Left a couple of nit comments. LGTM overall

@Ltadrian Ltadrian force-pushed the agracia/SQC-480-add-sslmode-hyperdrive branch from 278815b to 493999c Compare March 31, 2025 17:15
emily-shen
emily-shen reviewed Mar 31, 2025
View reviewed changes
@Ltadrian Ltadrian force-pushed the agracia/SQC-480-add-sslmode-hyperdrive branch 5 times, most recently from e254c5f to ee84ca2 Compare March 31, 2025 21:42
@workers-devprod workers-devprod mentioned this pull request Apr 1, 2025
Closed
petebacondarwin
petebacondarwin approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll run the e2e tests; CR is approved and scheduled

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 1, 2025
@petebacondarwin petebacondarwin added the e2e Run wrangler + vite-plugin e2e tests on a PR label Apr 1, 2025
@petebacondarwin petebacondarwin force-pushed the agracia/SQC-480-add-sslmode-hyperdrive branch from ee84ca2 to c427e75 Compare April 1, 2025 09:04
@petebacondarwin petebacondarwin merged commit 3993374 into cloudflare:main Apr 1, 2025
36 of 38 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 1, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Apr 1, 2025
@holopin-bot
Copy link

holopin-bot bot commented Apr 1, 2025

Congratulations @Ltadrian, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm8ybttbf56350cjml2sfhbfr

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu left review comments

@emily-shen emily-shen emily-shen left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees

No one assigned

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ltadrian @CarmenPopoviciu @petebacondarwin @emily-shen @workers-devprod